<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div style="font-family: monospace; font-size: 15px;">[RESENT MESSAGE — see <a href="https://mail.haskell.org/pipermail/ghc-devops-group/2017-October/000004.html" class="">https://mail.haskell.org/pipermail/ghc-devops-group/2017-October/000004.html</a>]</div><div class=""><br class=""></div><div><br class=""><blockquote type="cite" class=""><div class=""><span style="font-family: -webkit-system-font, "Helvetica Neue", Helvetica, sans-serif;" class=""><b class="">From: </b></span><span style="font-family: -webkit-system-font, "Helvetica Neue", Helvetica, sans-serif;" class="">"Boespflug, Mathieu" <<a href="mailto:m@tweag.io" class="">m@tweag.io</a>></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Subject: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><b class="">Aw: [GHC DevOps Group] Phabricator -> GitHub?</b><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Date: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">9. Oktober 2017 um 23:02:32 GMT+11<br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">To: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">Manuel M T Chakravarty <<a href="mailto:manuel.chakravarty@tweag.io" class="">manuel.chakravarty@tweag.io</a>><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Cc: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">"<a href="mailto:ghc-devops-group@haskell.org" class="">ghc-devops-group@haskell.org</a>" <<a href="mailto:ghc-devops-group@haskell.org" class="">ghc-devops-group@haskell.org</a>><br class=""></span></div><br class=""><div class=""><div class="">On 9 October 2017 at 13:23, Manuel M T Chakravarty<br class=""><<a href="mailto:manuel.chakravarty@tweag.io" class="">manuel.chakravarty@tweag.io</a>> wrote:<br class=""><blockquote type="cite" class="">Simon Peyton Jones <<a href="mailto:simonpj@microsoft.com" class="">simonpj@microsoft.com</a>>:<br class=""><br class="">I don’t have a well-informed opinion, but in instinct is to follow the<br class="">mainstream even if a technically-better alternative exists, unless it’s a<br class="">LOT better. For the reasons Manuel outlines.<br class=""><br class="">Am I right that GitHub code review has improved?<br class=""><br class="">It has improved since this issue was discussed last. I believe one of the<br class="">main criticisms in the past was that while people could comment on<br class="">individual lines of a proposed contributions (aka pull request), there was<br class="">no way to tie those into a code review unit. This facility has since been<br class="">added.<br class=""></blockquote><br class="">To add to Manuel's comment - from a practical perspective what this<br class="">meant was that in the past if someone had 15 comments to make about<br class="">your pull request during review, you'd be bombarded with 15 emails in<br class="">your inbox. Simon M in particular pointed this out as particularly<br class="">problematic. And I agree. But as Manuel points out, GitHub has now<br class="">fixed this: a reviewer can send a bunch of comments in one batch, and<br class="">attach semantics to it (accept PR / request changes / refuse it etc).<br class=""><br class=""><blockquote type="cite" class="">Moreover, contributors can now request code reviews from specific<br class="">reviewers and the repositories can be configured such that contributions<br class="">cannot be merged until signed off by a reviewer.<br class=""></blockquote><br class="">Indeed. There is also a new related feature, and likely one that may<br class="">prove quite useful for a large project like GHC. You can enforce<br class="">things like "all changes to template-haskell need to be reviewed by<br class="">person X", or "person Y is the gatekeeper for all type checker related<br class="">changes" etc. That said - this is just extra mechanism that large<br class="">GitHub projects (and there are many) have lived without it okay until<br class="">recently (e.g. the Nixpkgs project, with ~2k commits every month).<br class="">_______________________________________________<br class="">Ghc-devops-group mailing list<br class=""><a href="mailto:Ghc-devops-group@haskell.org" class="">Ghc-devops-group@haskell.org</a><br class="">https://haskell.org/cgi-bin/mailman/listinfo/ghc-devops-group<br class=""></div></div></blockquote><blockquote type="cite" class=""><div class="">Anfang der weitergeleiteten Nachricht:</div><br class="Apple-interchange-newline"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Von: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">"Boespflug, Mathieu" <<a href="mailto:m@tweag.io" class="">m@tweag.io</a>><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Betreff: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><b class="">Aw: [GHC DevOps Group] Phabricator -> GitHub?</b><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Datum: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">9. Oktober 2017 um 23:02:32 GMT+11<br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">An: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">Manuel M T Chakravarty <<a href="mailto:manuel.chakravarty@tweag.io" class="">manuel.chakravarty@tweag.io</a>><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Kopie: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">Simon Peyton-Jones <<a href="mailto:simonpj@microsoft.com" class="">simonpj@microsoft.com</a>>, "<a href="mailto:ghc-devops-group@haskell.org" class="">ghc-devops-group@haskell.org</a>" <<a href="mailto:ghc-devops-group@haskell.org" class="">ghc-devops-group@haskell.org</a>><br class=""></span></div><br class=""><div class=""><div class="">On 9 October 2017 at 13:23, Manuel M T Chakravarty<br class=""><<a href="mailto:manuel.chakravarty@tweag.io" class="">manuel.chakravarty@tweag.io</a>> wrote:<br class=""><blockquote type="cite" class="">Simon Peyton Jones <<a href="mailto:simonpj@microsoft.com" class="">simonpj@microsoft.com</a>>:<br class=""><br class="">I don’t have a well-informed opinion, but in instinct is to follow the<br class="">mainstream even if a technically-better alternative exists, unless it’s a<br class="">LOT better. For the reasons Manuel outlines.<br class=""><br class="">Am I right that GitHub code review has improved?<br class=""><br class="">It has improved since this issue was discussed last. I believe one of the<br class="">main criticisms in the past was that while people could comment on<br class="">individual lines of a proposed contributions (aka pull request), there was<br class="">no way to tie those into a code review unit. This facility has since been<br class="">added.<br class=""></blockquote><br class="">To add to Manuel's comment - from a practical perspective what this<br class="">meant was that in the past if someone had 15 comments to make about<br class="">your pull request during review, you'd be bombarded with 15 emails in<br class="">your inbox. Simon M in particular pointed this out as particularly<br class="">problematic. And I agree. But as Manuel points out, GitHub has now<br class="">fixed this: a reviewer can send a bunch of comments in one batch, and<br class="">attach semantics to it (accept PR / request changes / refuse it etc).<br class=""><br class=""><blockquote type="cite" class="">Moreover, contributors can now request code reviews from specific<br class="">reviewers and the repositories can be configured such that contributions<br class="">cannot be merged until signed off by a reviewer.<br class=""></blockquote><br class="">Indeed. There is also a new related feature, and likely one that may<br class="">prove quite useful for a large project like GHC. You can enforce<br class="">things like "all changes to template-haskell need to be reviewed by<br class="">person X", or "person Y is the gatekeeper for all type checker related<br class="">changes" etc. That said - this is just extra mechanism that large<br class="">GitHub projects (and there are many) have lived without it okay until<br class="">recently (e.g. the Nixpkgs project, with ~2k commits every month).<br class=""></div></div></blockquote><blockquote type="cite" class=""><div class="">Anfang der weitergeleiteten Nachricht:</div><br class="Apple-interchange-newline"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Von: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">"Boespflug, Mathieu" <<a href="mailto:m@tweag.io" class="">m@tweag.io</a>><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Betreff: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class=""><b class="">Aw: [GHC DevOps Group] Phabricator -> GitHub?</b><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Datum: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">9. Oktober 2017 um 23:02:32 GMT+11<br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">An: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">Manuel M T Chakravarty <<a href="mailto:manuel.chakravarty@tweag.io" class="">manuel.chakravarty@tweag.io</a>><br class=""></span></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px;" class=""><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif; color:rgba(0, 0, 0, 1.0);" class=""><b class="">Kopie: </b></span><span style="font-family: -webkit-system-font, Helvetica Neue, Helvetica, sans-serif;" class="">Simon Peyton-Jones <<a href="mailto:simonpj@microsoft.com" class="">simonpj@microsoft.com</a>>, "<a href="mailto:ghc-devops-group@haskell.org" class="">ghc-devops-group@haskell.org</a>" <<a href="mailto:ghc-devops-group@haskell.org" class="">ghc-devops-group@haskell.org</a>><br class=""></span></div><br class=""><div class=""><div class="">On 9 October 2017 at 13:23, Manuel M T Chakravarty<br class=""><<a href="mailto:manuel.chakravarty@tweag.io" class="">manuel.chakravarty@tweag.io</a>> wrote:<br class=""><blockquote type="cite" class="">Simon Peyton Jones <<a href="mailto:simonpj@microsoft.com" class="">simonpj@microsoft.com</a>>:<br class=""><br class="">I don’t have a well-informed opinion, but in instinct is to follow the<br class="">mainstream even if a technically-better alternative exists, unless it’s a<br class="">LOT better. For the reasons Manuel outlines.<br class=""><br class="">Am I right that GitHub code review has improved?<br class=""><br class="">It has improved since this issue was discussed last. I believe one of the<br class="">main criticisms in the past was that while people could comment on<br class="">individual lines of a proposed contributions (aka pull request), there was<br class="">no way to tie those into a code review unit. This facility has since been<br class="">added.<br class=""></blockquote><br class="">To add to Manuel's comment - from a practical perspective what this<br class="">meant was that in the past if someone had 15 comments to make about<br class="">your pull request during review, you'd be bombarded with 15 emails in<br class="">your inbox. Simon M in particular pointed this out as particularly<br class="">problematic. And I agree. But as Manuel points out, GitHub has now<br class="">fixed this: a reviewer can send a bunch of comments in one batch, and<br class="">attach semantics to it (accept PR / request changes / refuse it etc).<br class=""><br class=""><blockquote type="cite" class="">Moreover, contributors can now request code reviews from specific<br class="">reviewers and the repositories can be configured such that contributions<br class="">cannot be merged until signed off by a reviewer.<br class=""></blockquote><br class="">Indeed. There is also a new related feature, and likely one that may<br class="">prove quite useful for a large project like GHC. You can enforce<br class="">things like "all changes to template-haskell need to be reviewed by<br class="">person X", or "person Y is the gatekeeper for all type checker related<br class="">changes" etc. That said - this is just extra mechanism that large<br class="">GitHub projects (and there are many) have lived without it okay until<br class="">recently (e.g. the Nixpkgs project, with ~2k commits every month).<br class=""></div></div></blockquote></div><br class=""></body></html>